Improve the block and patterns search algorithm #25105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
force-pushed
the
update/better-search-algorithm
branch
from
557e638 to
6a15336
Compare
|
Size Change: +171 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
mtias
reviewed
Sep 7, 2020
mtias
reviewed
Sep 7, 2020
Co-authored-by: Miguel Fonseca <[email protected]>
Co-authored-by: Miguel Fonseca <[email protected]>
ntsekouras
reviewed
Sep 7, 2020
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
I would probably add a unit test searchItems new ordering. Other than that and some minor comments this looks good!
mcsf
reviewed
Sep 7, 2020
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14868
closes #24651
This PR improves the search algorithm for blocks and patterns by implementing a rank-based search:
The blocks are ordered as follows:
Also, if the block is a "core" block, it has a bonus point.
Note that the search algorithm doesn't work properly for block variations, the issue there is not from the search algorithm but more from the inserter where we consider the variations and the blocks as a single "item". A separate refactoring should be done to improve that.