Polish menu item icon locations. #25106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
requested review from
ajitbohra,
chrisvanpatten,
ellatrix and
youknowriad
as code owners
|
Size Change: -12 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Sep 7, 2020
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Looks good! Thanks! 💯 - Green CI and let's land this!
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent polish of popover menus (icons on the right), the Replace Image flow and Transform flows were a little lacking:
This PR fixes that by polishing a little bit. The replace flow now has correct padding, a separator, and the dashicon for media has been updated to reflect what's in the WordPress Design Library figma file:
Block transform menu items are shown on the left, to match what shows up in the slash command: