Skip to content

Cover Block: Show spinner while uploading #25401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frontdevde merged 6 commits into from
Oct 5, 2020
Merged

Cover Block: Show spinner while uploading #25401

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a41ac7f
Cover Block: Show spinner while uploading
Sep 17, 2020
28742ba
Cover block: find media type and show the file being uploaded
Sep 17, 2020
1007897
Replace double isBlobURL function call with a single one
Oct 2, 2020
423592c
Make spinner position more abstract
Oct 2, 2020
9b630b2
Makes first letter uppercase in comment
Oct 2, 2020
eae7509
Adds z-index to absolute element
Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace double isBlobURL function call with a single one
  • Loading branch information
cpap committed Oct 2, 2020
commit 1007897c1650116a5c66a1e732d4397fcb24998c
5 changes: 3 additions & 2 deletions packages/block-library/src/cover/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ function CoverEdit( {
setGradient,
} = __experimentalUseGradient();
const onSelectMedia = attributesFromMedia( setAttributes );
const isBlogUrl = isBlobURL( url );

const toggleParallax = () => {
setAttributes( {
Expand Down Expand Up @@ -472,7 +473,7 @@ function CoverEdit( {
{
'is-dark-theme': isDark,
'has-background-dim': dimRatio !== 0,
'is-transient': isBlobURL( url ),
'is-transient': isBlogUrl,
'has-parallax': hasParallax,
[ overlayColor.class ]: overlayColor.class,
'has-background-gradient': gradientValue,
Expand Down Expand Up @@ -539,7 +540,7 @@ function CoverEdit( {
style={ { objectPosition: positionValue } }
/>
) }
{ isBlobURL( url ) && <Spinner /> }
{ isBlogUrl && <Spinner /> }
<InnerBlocks
__experimentalTagName="div"
__experimentalPassedProps={ {
Expand Down