Skip to content

Spacer block: Allow 1px height and improve usability in the editor #25464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stokesman wants to merge 1 commit into from
Closed

Spacer block: Allow 1px height and improve usability in the editor #25464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/block-library/src/spacer/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { compose, withInstanceId } from '@wordpress/compose';
import { withDispatch } from '@wordpress/data';
import { useState } from '@wordpress/element';

const MIN_SPACER_HEIGHT = 20;
const MIN_SPACER_HEIGHT = 1;
const MAX_SPACER_HEIGHT = 500;

const SpacerEdit = ( {
Expand Down
8 changes: 7 additions & 1 deletion packages/block-library/src/spacer/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
.block-editor-block-list__block[data-type="core/spacer"] {
min-height: 20px;
display: flex;
flex-direction: column;
justify-content: center;
}

.block-library-spacer__resize-container.has-show-handle {
background: $gray-100;

Expand All @@ -8,7 +15,6 @@

.block-library-spacer__resize-container {
clear: both;
margin-bottom: $default-block-margin;

// Don't show the horizontal indicator.
.components-resizable-box__handle::before {
Expand Down