Firefox: fix disappearing toolbar#25554
Merged
ZebulanStanphill merged 1 commit intomasterfrom Sep 23, 2020
Merged
Conversation
|
Size Change: -8 B (0%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Sep 23, 2020
Member
aristath
left a comment
aristath
left a comment
There was a problem hiding this comment.
LGTM. Tested on Ubuntu using Firefox, it now works as expected 👍
ZebulanStanphill
added
[Priority] High
ZebulanStanphill
approved these changes
Sep 23, 2020
Member
ZebulanStanphill
left a comment
ZebulanStanphill
left a comment
There was a problem hiding this comment.
Thanks for getting on this so quickly, @ellatrix! And thanks for spotting and reporting, @talldan and @aristath.
Tested on KDE Neon with Firefox 80.0.1. Also tested on Chromium to make sure it's still working there. Everything seems to be working correctly again!
There's a failing test in the Static Analysis GitHub action:
[1] /home/runner/work/gutenberg/gutenberg/packages/block-library/src/navigation/index.js
[1] 24:18 error Replace `·'A·collection·of·blocks·that·allow·visitors·to·get·around·your·site.'·` with `⏎↹↹'A·collection·of·blocks·that·allow·visitors·to·get·around·your·site.'⏎↹` prettier/prettier
However, it's just a formatting issue that is totally unrelated to this PR. So we should merge this as soon as it lets us.
Member
|
(I think it just needs a rebase.) |
ellatrix
force-pushed
the
fix/toolbar-hover-firefox
branch
from
7503cd7 to
fda9eb0
Compare
| function onMouseLeave( { buttons } ) { | ||
| // The primary button must be pressed to initiate selection. | ||
| // See https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/buttons | ||
| // See https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/which |
Member
There was a problem hiding this comment.
I think this link can be removed since it's no longer relevant.
ZebulanStanphill
added a commit
that referenced
this pull request
Sep 23, 2020
The link is no longer relevant after #25554.
ZebulanStanphill
added a commit
that referenced
this pull request
Sep 24, 2020
The link is no longer relevant after #25554.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #25526.
The cause of this bug is the switch from a React synthetic event to a native event. It seems that the
buttonsproperty didn't work correctly in the past for Firefox, but it works correctly for the native event.How has this been tested?
Screenshots
Types of changes
Checklist: