Skip to content

Cache Global-Styles #25680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aristath merged 2 commits into from
Nov 13, 2020
Merged

Cache Global-Styles #25680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c43a84
Cache for a minute using a transient
aristath Sep 28, 2020
faaa444
Merge branch 'master' into try/global-styles-cache-25678
aristath Oct 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions lib/global-styles.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,24 @@ function gutenberg_experimental_global_styles_flatten_styles_tree( $styles ) {
* @return string Stylesheet.
*/
function gutenberg_experimental_global_styles_get_stylesheet( $tree ) {

// Check if we can use cached.
$can_use_cached = (
( ! defined( 'WP_DEBUG' ) || ! WP_DEBUG ) &&
( ! defined( 'SCRIPT_DEBUG' ) || ! SCRIPT_DEBUG ) &&
( ! defined( 'REST_REQUEST' ) || ! REST_REQUEST ) &&
! is_admin()
);

if ( $can_use_cached ) {

// Check if we have the styles already cached.
$cached = get_transient( 'global_styles' );
Copy link
Member

@jorgefilipecosta jorgefilipecosta Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we have extensibility we need to document very well what plugins can do. If a plugin changes global styles depending on the page, for example, the caching solution makes things not work well because we have a global cache, so the value will be equal on all pages.

if ( $cached ) {
return $cached;
}
}

$stylesheet = '';
$block_data = gutenberg_experimental_global_styles_get_block_data();
foreach ( array_keys( $tree ) as $block_name ) {
Expand Down Expand Up @@ -644,6 +662,13 @@ function gutenberg_experimental_global_styles_get_stylesheet( $tree ) {
$stylesheet .= 'a{color:var(--wp--style--color--link, #00e);}';
}

if ( $can_use_cached ) {

// Cache for a minute.
// This cache doesn't need to be any longer, we only want to avoid spikes on high-trafic sites.
set_transient( 'global_styles', $stylesheet, MINUTE_IN_SECONDS );
}

return $stylesheet;
}

Expand Down