Skip to content

Color picker improvements, first round #2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afercia merged 8 commits into from
Sep 29, 2017
Merged

Color picker improvements, first round #2680

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ac0174d
Use aria-pressed, fix valid code, add missing aria-label.
afercia Sep 5, 2017
4900ccc
Properly toggle the Custom color picker.
afercia Sep 5, 2017
f059e92
Fix focus style on the Custom color picker toggle.
afercia Sep 5, 2017
a612cdd
Properly rename call to toggle picker function.
afercia Sep 5, 2017
bc81f6b
Process CR.
afercia Sep 29, 2017
0503875
Improve color buttons vertical alignment.
afercia Sep 29, 2017
4c4de38
Make ESLint happy.
afercia Sep 29, 2017
a4d10f7
Remove unused stopPropagation method
aduth Sep 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Properly rename call to toggle picker function.
  • Loading branch information
@afercia
afercia committed Sep 29, 2017
commit a612cddc9ec5b14011a1021c168fd28f1375c54c
2 changes: 1 addition & 1 deletion blocks/color-palette/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class ColorPalette extends Component {
color={ value }
onChangeComplete={ ( color ) => {
onChange( color.hex );
this.closePicker();
this.togglePicker();
} }
style={ { width: '100%' } }
disableAlpha
Expand Down