-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[RNMobile] Refactor: gallery to nested image blocks #26823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
dratwas
wants to merge
152
commits into
refactor/gallery-to-nested-image-blocks
from
rnmobile/refactor/gallery-to-nested-image-blocks
Closed
Changes from 1 commit
Commits
Show all changes
152 commits
Select commit
Hold shift + click to select a range
729907f
Refactor gallery to use nested image blocks
53cf527
Fix issue with images not loading on first selection from media gallery
4d95e95
Remove the default columns setting as we don't have access to innerBl…
0437b8b
Revert "Remove the default columns setting as we don't have access to…
18dd0a2
Add image count so we can work out default columns as innerBlocks not…
fdc4d89
Update Gallery to nested image blocks
f10fc98
Fix issue with images not loading on first selection from media gallery
e9bfd5f
Remove the default columns setting as we don't have access to innerBl…
1534386
Revert "Remove the default columns setting as we don't have access to…
38ab027
Add image count so we can work out default columns as innerBlocks not…
cc05d60
Disable the innerBlocks dropzones so drag drop works same as existing…
9b0abcc
Lint changes
57abff0
WIP
dratwas 74d0fb7
Revert "Lint changes"
2b17d24
Revert "Disable the innerBlocks dropzones so drag drop works same as …
98454b1
Suggested solution for handling multiple file drop into gallery
7d4c2d3
Remove non image files from drag and drop and disable individual imag…
91faab5
Fix transform to individual images
e0d11b1
Fix transform from individual images
795fd47
fix dirty-image-options
dratwas 2ec63f1
fix spacing
dratwas 2d9a56e
Revert drag and drop transform changes
a868f58
Add gallery transform to image block to override the default gallery …
c0f043d
Add imageCrop, blockProps to block-list and style fixes
dratwas c2fbfa8
Temporary remove the gallery from initial-html
dratwas 4f7b505
Merge branch 'refactor/gallery-to-nested-image-blocks' into rnmobile/…
dratwas 051a2b8
Add gallery caption
dratwas 39e758f
lint fix
dratwas b1d9072
Use grid Component instead of numColumns
dratwas fb6fea4
Merge branch 'refactor/gallery-to-nested-image-blocks' into rnmobile/…
dratwas 50a7719
fix for Android
dratwas 042a17b
Fix Android
dratwas 252916d
Use grid in list item and fix adding of new images
dratwas ca8f3db
Move handling of file uploads to Gallery from media placeholder
324dddb
split innerblocks mapping into separate effect to reduce chatter
5c4018e
Merge branch 'refactor/gallery-to-nested-image-blocks' into rnmobile/…
dratwas 67bfc4f
Use Picker for dirt image options and add some fixes
dratwas 291bfb4
Add useMemo to currentImageOptions
0d96752
reuse existing innerBlocks rather than recreating with every new imag…
7eaa8bc
Switch to useMemo for updating local image const instead of local com…
f0a1e36
Fix issue with image sizing not being available on initial load of co…
d85f841
Memoise the useImageSizes hook
32ac8dd
Fix issue with media browser defaulting to edit gallery view
a32987a
Fix missed incorrect use of addToGallery
e7b694d
fix initial Picker
dratwas f90d1b5
Change the header text of picker
dratwas 77ca738
Merge branch 'refactor/gallery-to-nested-image-blocks' into rnmobile/…
dratwas e1fe0eb
fix android dirty images options
dratwas 2d400ea
Add some extra effects for getting the imageData as the getMedia call…
76fe72e
Simplify the imageData by using a useSelect
1243c63
Another optimisation - only return a new imageData reference if all i…
8aeec07
Refactored Gallery: Add loading state to gallery image size options (…
aaronrobertshaw 9658eef
Initial deprecations commit
b9eebc5
Fix issue with linkDestination not being applied in migration
493196a
Refactor gallery deprecations
aaronrobertshaw b48028b
Fix missing attributes from migration
aaronrobertshaw 023d391
Update deprecation to set allowResize
aaronrobertshaw 6c059e1
Fix issue with crop not working when certain plugins are loaded
e412366
Fix SCSS lint errors
aaronrobertshaw b0d477c
Update the block example
aae1a7e
Linting fixes
29a8e08
Fix the e2e test and the accessibility issue with having aria group r…
933a60f
fix linting issues
33ddaff
Fix frontend omission of wp-block-image class
aaronrobertshaw f1f2fe7
apply CR suggestions
dratwas 7a9cad4
Merge branch 'refactor/gallery-to-nested-image-blocks' into rnmobile/…
dratwas cf101ce
change deprecation to use imageCount as isEligible check as it seems …
7e306bf
Merge branch 'refactor/gallery-to-nested-image-blocks' into rnmobile/…
dratwas e51389c
fix overflow
dratwas 789019c
fix dirty-image-options
dratwas e63870c
Update Gallery to nested image blocks
5a0ab09
Fix issue with images not loading on first selection from media gallery
3a0f2aa
Remove the default columns setting as we don't have access to innerBl…
77ac0f2
Revert "Remove the default columns setting as we don't have access to…
a365dc7
Add image count so we can work out default columns as innerBlocks not…
085b5fc
Disable the innerBlocks dropzones so drag drop works same as existing…
c2d5c85
Lint changes
970bf6f
Revert "Lint changes"
9e44909
Revert "Disable the innerBlocks dropzones so drag drop works same as …
a9ca983
Suggested solution for handling multiple file drop into gallery
e33e0c2
Remove non image files from drag and drop and disable individual imag…
c4cb26b
Fix transform to individual images
f3726b6
Fix transform from individual images
8a296f7
Revert drag and drop transform changes
3882fb6
Add gallery transform to image block to override the default gallery …
3fe9007
Move handling of file uploads to Gallery from media placeholder
6660d86
split innerblocks mapping into separate effect to reduce chatter
54c0ca7
Add useMemo to currentImageOptions
c63dd6d
reuse existing innerBlocks rather than recreating with every new imag…
f636509
Switch to useMemo for updating local image const instead of local com…
d85294d
Fix issue with image sizing not being available on initial load of co…
99cc601
Memoise the useImageSizes hook
f873ef6
Fix issue with media browser defaulting to edit gallery view
ebd462b
Fix missed incorrect use of addToGallery
05c910b
Add some extra effects for getting the imageData as the getMedia call…
00ba2c9
Simplify the imageData by using a useSelect
8b7130e
Another optimisation - only return a new imageData reference if all i…
dcecc15
Refactored Gallery: Add loading state to gallery image size options (…
aaronrobertshaw 066d002
Initial deprecations commit
65455f8
Fix issue with linkDestination not being applied in migration
1f46bb7
Refactor gallery deprecations
aaronrobertshaw fe2afc7
Fix missing attributes from migration
aaronrobertshaw c60f472
Update deprecation to set allowResize
aaronrobertshaw 70cc084
Fix issue with crop not working when certain plugins are loaded
87829c2
Fix SCSS lint errors
aaronrobertshaw 32e2527
Update the block example
5bbf634
Linting fixes
47213ac
Fix the e2e test and the accessibility issue with having aria group r…
da7963e
fix linting issues
d92d2a0
Fix frontend omission of wp-block-image class
aaronrobertshaw 83b5821
change deprecation to use imageCount as isEligible check as it seems …
e669798
Move back to a single deprecations file and reorder in array
4e97415
Remove additional check in v5 isEligible
4d02b9d
Fix the v4 migration
bfc97df
Fix styles for Safari compatibility
aaronrobertshaw 6d89c0e
Remove unnecessary gallery editor styles
aaronrobertshaw 4c48cc2
Fix typo in deprecations
aaronrobertshaw 41b561f
Restore styles to render deprecated gallery versions
aaronrobertshaw ae1d2d6
Avoid applying flex styles to IE11
aaronrobertshaw b64b28b
Add additional selector to prevent the hidden individual image drop z…
f791150
IE11 styling improvements
aaronrobertshaw f3f5f20
Apply default style class to new images added to gallery
d39db2b
fix linting issues
39ae626
Move block props to the outer wrapper
f0771fa
Revert "Move block props to the outer wrapper"
0248332
Revert "Revert "Move block props to the outer wrapper""
dfb5c33
Fetch media if isListItem is true
f94e3ae
Change context from isListItem to isGrouped
cc9a294
Remove external div wrapper by moving InnerBlocks to a fragment
746a480
remove extra wrapper around media placeholder and caption and use fle…
1014505
Revert "remove extra wrapper around media placeholder and caption and…
35b34ab
Revert "Remove external div wrapper by moving InnerBlocks to a fragment"
afa436c
another update to image wrapper
545dd75
put media uploader outside figure so structure matches front end
2f4f9a1
Replace div with View for the sake of native code
150d907
Move setting of attributes to the child images
31028d5
Gallery Block Refactor: Account for null image ids in gallery migrati…
glendaviesnz 70e97b6
Remove the gradient and put caption under image if is-rounded style a…
glendaviesnz b6c5ce5
Remove outer div wrapper
aa33399
Keep image margins while dragging sibling
aaronrobertshaw f5e1485
Fix e2e test expected markup to match new structure
047d8a7
merge with base branch
dratwas 3fbcda3
resolve conflicts
dratwas 835c7be
remove unused deprecation files
dratwas a789cb4
revert changes in picker
dratwas 88fc544
fix web scss changes after rebase
dratwas 187d5ac
remove not needed change
dratwas a31a9ec
remove dirty image options
dratwas 8a546ff
rever changes in gallery edit
dratwas cd3c3f4
WIP use context to set target destination and slug
dratwas ad6d313
Fix inherted image props in gallery
dratwas e231bbe
fix key in bloc-styles
dratwas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add gallery caption
- Loading branch information
commit 051a2b832882ddb43fe71621d32663601fd30f87
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.