Skip to content

is-shallow-equal: Convert to ESM #26833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarayourfriend merged 6 commits into from
Nov 13, 2020
Merged

is-shallow-equal: Convert to ESM #26833

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fe5e0ee
is-shallow-equal: Convert to ESM
sarayourfriend Nov 9, 2020
088ad28
is-shallow-equal: Fix test import for ci
sarayourfriend Nov 9, 2020
c53d4fc
Fix react-native module resolution
sarayourfriend Nov 11, 2020
91328a6
Clean up unnecessary code.
sarayourfriend Nov 11, 2020
809fa9b
Update files entry
sarayourfriend Nov 11, 2020
7149f36
Update benchmark instructions and CHANGELOG
sarayourfriend Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update benchmark instructions and CHANGELOG
  • Loading branch information
@sarayourfriend
sarayourfriend committed Nov 12, 2020
commit 7149f36a26c65e3a3388a389a12a6178c136d681
4 changes: 4 additions & 0 deletions packages/is-shallow-equal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Breaking Change

- Re-write using ES Modules causing CJS default import to change from `require('@wordpress/is-shallow-equal)` to `require('@wordpress/is-shallow-equal).default`. ([#26833](https://github.com/WordPress/gutenberg/pull/26833))

## 2.0.0 (2020-04-15)

### Breaking Change
Expand Down
6 changes: 3 additions & 3 deletions packages/is-shallow-equal/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,10 @@ The following results were produced under Node v10.15.3 (LTS) on a MacBook Pro (
You can run the benchmarks yourselves by cloning the repository, installing dependencies, and running the `benchmark/index.js` script:

```
git clone https://github.com/WordPress/packages.git
cd packages/packages/is-shallow-equal
git clone https://github.com/WordPress/gutenberg.git
npm install
node benchmark
npm run build:packages
node ./packages/is-shallow-equal/benchmark
```

<br/><br/><p align="center"><img src="https://s.w.org/style/images/codeispoetry.png?1" alt="Code is Poetry." /></p>
2 changes: 1 addition & 1 deletion packages/is-shallow-equal/benchmark/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Promise.all( [
require( '..' ).isShallowEqualObjects,
require( '..' ).isShallowEqualArrays,
],
[ '@wordpress/is-shallow-equal', require( '..' ) ],
[ '@wordpress/is-shallow-equal', require( '..' ).default ],
[ 'shallowequal', shallowequal ],
[
'shallow-equal (type specific)',
Expand Down