Skip to content

Conversation

@youknowriad
Copy link
Contributor

fixes #2646

I'm not sure why this buffer zone exists in the first place, but making it smaller makes it a better experience IMO.

@youknowriad youknowriad added the [Type] Enhancement A suggestion for improvement. label Sep 7, 2017
@youknowriad youknowriad self-assigned this Sep 7, 2017
@codecov
Copy link

codecov bot commented Sep 7, 2017

Codecov Report

Merging #2695 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2695   +/-   ##
=======================================
  Coverage   33.16%   33.16%           
=======================================
  Files         182      182           
  Lines        5530     5530           
  Branches      963      963           
=======================================
  Hits         1834     1834           
  Misses       3130     3130           
  Partials      566      566
Impacted Files Coverage Δ
editor/modes/visual-editor/block-list.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b7923...75bac22. Read the comment docs.

@aduth
Copy link
Member

aduth commented Sep 7, 2017

Not sure I feel entirely comfortable reviewing something when we don't know the original intent and therefore the impact of the changes 😄

@aduth
Copy link
Member

aduth commented Sep 20, 2017

cc @iseulde

@mtias mtias merged commit 687ad8c into master Sep 20, 2017
@aduth aduth deleted the update/smaller-multiselect-buffer branch September 20, 2017 17:50
@ellatrix
Copy link
Member

ellatrix commented Sep 20, 2017

I agree with this change. May need more tweaking. @jasmussen suggested setting it really high. back when it was first added, but I agree it's weird on small blocks.

@jasmussen
Copy link
Contributor

Definitely tune it if need be. I did suggest setting it SUPER high, because I feel like it's easier to pull back from up high, than the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drag to select doesn't kick in until the third block

6 participants