Skip to content

Conversation

@aduth
Copy link
Member

@aduth aduth commented Sep 8, 2017

See: #1974 (comment)

This pull request seeks to download the api-request.js shim directly from GitHub, instead of through rawgit.com. The latter is necessary in cases where we would reference the URL by script tag directly, but given the behavior of vendor scripts to download the copy server-side to the plugin directory, this is not relevant for our usage.

Testing instructions:

Verify that the api-request.js shim continues to load as expected.

  1. (Prerequisite) Your site must be running WordPress < 4.9-alpha
  2. Delete your local copy if it exists: rm vendor/api-request.*
  3. Navigate to Gutenberg > New Post
  4. Note that the page loads without any errors

@aduth aduth added the Framework Issues related to broader framework topics, especially as it relates to javascript label Sep 8, 2017
@aduth aduth requested a review from mcsf September 8, 2017 14:38
Copy link
Contributor

@mcsf mcsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues related to broader framework topics, especially as it relates to javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants