Visual Mode: Extract content inserter as separate component #2706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Feature] Inserter
Codecov Report
@@ Coverage Diff @@
## master #2706 +/- ##
=========================================
+ Coverage 33.42% 33.7% +0.27%
=========================================
Files 188 189 +1
Lines 5639 5629 -10
Branches 981 978 -3
=========================================
+ Hits 1885 1897 +12
+ Misses 3181 3162 -19
+ Partials 573 570 -3
Continue to review full report at Codecov.
|
Contributor
|
closes #2726 |
aduth
force-pushed
the
fix/content-inserter-arrow-nav
branch
from
1168d05 to
db800c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to refactor a separate component of the "Continue Writing" controls currently rendered as children of the
<VisualEditorBlockList />. Importantly, this resolves an issue where attempting to navigate the content inserter with the keyboard will cause focus to shift between blocks, due to the behavior of the<WritingFlow />component introduced in #2424. Since the inserter controls are not relevant to writing flow nor particularly the rendering of the list of blocks, it is sensible to isolate as its own component.Testing instructions:
Verify that there are no regressions in the insertion of a new block using the inserter from Visual post content. Particularly, note that you can insert a block using keyboard navigation in the Inserter popover.
Ensure unit tests pass: