Skip to content

Remove the gradient and put caption under image if is-rounded style applied #27869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glendaviesnz merged 4 commits into from
Dec 24, 2020
Merged

Remove the gradient and put caption under image if is-rounded style applied #27869

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c93eb0
Remove the gradient and put caption under image if is-rounded style a…
Dec 23, 2020
921dbbc
Remove redundant styles
Dec 23, 2020
ac4695b
Just remove background on IE and keep caption absolute positioned
Dec 23, 2020
6fa166a
Add alignment fixes for non cropped images
Dec 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion packages/block-library/src/gallery/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
flex-grow: 1;
justify-content: center;
position: relative;

margin-top: auto;
margin-bottom: auto;
// IE11 doesn't like the "flex-direction: column;" here.
@supports ( position: sticky ) {
flex-direction: column;
Expand Down Expand Up @@ -72,13 +73,52 @@
display: inline;
}
}

&.is-style-rounded {
> div,
> a {
// Not supported in IE11.
@supports ( position: sticky ) {
flex: 1 1 auto;
}
}
figcaption {
background: none;
// Not supported in IE11.
@supports ( position: sticky ) {
flex: initial;
background: none;
color: inherit;
margin: 0;
padding: 10px 10px 9px;
position: relative;
}
}
}
}
}

figcaption {
flex-grow: 1;
}

// Non cropped images.
&:not(.is-cropped) {
figure.blocks-gallery-grid {
figure.wp-block-image:not(#individual-image) {
margin-top: auto;
margin-bottom: auto;
img {
margin-bottom: $grid-unit-20;
}

figcaption {
bottom: $grid-unit-20;
}
}
}
}

// Cropped Images.
&.is-cropped figure.blocks-gallery-grid figure.wp-block-image:not(#individual-image) {
> div:not(.components-drop-zone),
Expand Down