Update npm run native start to include cleanup
#28025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchowning
added
the
Mobile App - i.e. Android or iOS
2 tasks
mchowning
force-pushed
the
rnmobile/make_npm_run_start_a_safer_default
branch
from
7cf6143 to
6c58e94
Compare
Contributor
|
👋 I've spotted that the command |
Contributor
Author
Contributor
Oh sorry, I didn't saw the |
mchowning
requested review from
adamsilverstein,
adamziel,
ajlende,
atimmer,
cameronvoell,
dmsnell,
draganescu,
ellatrix,
guarani,
gziolo,
karmatosed,
kevin940726,
mapk,
mkaz,
mmtr,
nerrad,
noahtallen,
noisysocks,
ntwb and
oandregal
as code owners
mchowning
removed request for
TimothyBJacobs,
adamsilverstein,
ajitbohra,
ajlende,
atimmer,
cameronvoell,
chrisvanpatten,
dmsnell,
ellatrix,
guarani,
gziolo,
karmatosed,
kevin940726,
mapk,
mmtr,
nerrad,
noahtallen,
noisysocks,
ntwb,
oandregal,
swissspidy,
talldan and
tellthemachines
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
Contributor
I'd change the first command of this part because Ensure that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the
startscript to also do the cleanup previously done by the now-deprectedstart:resetscript. This is done to make the default script safer and to keep these commands consistent with gutenberg-mobile.How has this been tested?
Ensure that
npm run native start:resetandnpm run native start:quickboth start the metro bundler. Also check thatnpm run native startoutputs an error message directing the user to thenpm run native start:resetcommand.Types of changes
Tweaking the build setup
Checklist: