Selectors: Fix getBlock error for block not in state #2805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Feature] Block API
aduth
force-pushed
the
fix/get-block-error
branch
from
d43dcf1 to
bf70177
Compare
Codecov Report
@@ Coverage Diff @@
## master #2805 +/- ##
==========================================
+ Coverage 33.73% 33.81% +0.07%
==========================================
Files 190 190
Lines 5676 5678 +2
Branches 991 992 +1
==========================================
+ Hits 1915 1920 +5
+ Misses 3183 3181 -2
+ Partials 578 577 -1
Continue to review full report at Codecov.
|
youknowriad
reviewed
Sep 27, 2017
| expect( getBlock( state, 123 ) ).toBe( null ); | ||
| } ); | ||
|
|
||
| it( 'should merge meta attributes for the block', () => { |
youknowriad
approved these changes
Sep 27, 2017
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
This fixes the bug for me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2740 (comment)
This pull request seeks to resolve an error which occurs when trashing a selected block. It also improves the behavior of attributes mapped to meta fields, which currently does not work.
Testing instructions:
No blocks make use of meta fields attribute mapping. Instead, ensure tests pass:
Verify that an error does not occur when removing a selected block: