Conversation
kevin940726
added
[Type] Enhancement
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
kevin940726
commented
Jan 8, 2021
kevin940726
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
gziolo
approved these changes
Jan 8, 2021
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
Cool, thank you for working on it. I'm surprised that only one test needed an update.
Can you include a note about the breaking change since it's a new major version of puppeteer. It can be similar to what we had in the past:
https://github.com/WordPress/gutenberg/blob/master/packages/scripts/CHANGELOG.md#breaking-changes-3
kevin940726
force-pushed
the
update/puppeteer
branch
from
c1a9692 to
1f35c2c
Compare
Member
Author
Member
|
I merged this PR. The only failing e2e test is a known issue. Great work bringing Puppeteer to the latest version ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #23333.
How has this been tested?
npm run test-e2eTypes of changes
Breaking change
Checklist: