Merged
Conversation
… e2e test assertions can be made on blocks
…on over file names
talldan
added
[Type] Regression
talldan
requested review from
adamziel,
ajitbohra,
draganescu,
ellatrix,
kevin940726,
nerrad,
noisysocks,
ntwb and
tellthemachines
as code owners
talldan
commented
Jan 11, 2021
| templateLock: 'all', | ||
| hasFixedToolbar: true, | ||
| } } | ||
| useSubRegistry={ false } |
Contributor
Author
There was a problem hiding this comment.
This is needed, as without this wp.data.select( 'core/block-editor' ).getBlocks() isn't usable globally—but it's needed in the test to assert which blocks are present.
Contributor
There was a problem hiding this comment.
Just wanted to whine here. These true / false flags are so hard to pin down on meaning when reading code. Looking here it's not even mentioned.
|
Size Change: +9 B (0%) Total Size: 1.3 MB
ℹ️ View Unchanged
|
draganescu
approved these changes
Jan 11, 2021
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
Tested and the change makes the screen work as expected. The code and added test are 🆗
|
Hello @draganescu . Im getting this navigation screen error with the latest version of Gutenberg installed and the Block-Based Bosco theme and Attempt Recovery is not fixing it. Im attaching a screenshot of the error, can you please advise on the exact directory path for where I can update the code to fix this.
|
Contributor
Author
|
@MarvelMoe Thanks for reaching out. The fix for this will be released in Gutenberg 9.8. Fixing manually is a little tricky as the code is compiled when shipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28076.
The experimental navigation screen currently errors when trying to open it.
The
blockInformationisn't defined straight away, but that's not handled gracefully. I imagine this wasn't noticed because in other editors ListView only renders when the List View dropdown is opened, compared to the navigation screen where ListView is always rendered and visible.How has this been tested?
Added an e2e test.
Manual testing
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: