Components: Update dependencies shared with G2 components #28280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Components
Member
Author
|
It looks liek |
Member
Author
|
|
|
Size Change: -17 kB (-1%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
Member
Author
|
I still some unit tests failing: It looks like an issue with |
|
@gziolo Haii! Just a heads up, I merged in your G2 Component dependency update and made a release: |
gziolo
changed the title
gziolo
force-pushed
the
update/upgrade-dependencies-g2-components
branch
from
7df9ec3 to
9cfdbb1
Compare
gziolo
requested review from
ajitbohra,
chrisvanpatten and
ellatrix
as code owners
Member
Author
|
I also downgraded |
Member
Author
|
@ItsJonQ, I'm afraid that drag gestures no longer work on It works differently at: and in the local instance. They had two major version bumps:
Let me know if you have an idea how to fix it. Otherwise, this PR is good to go. |
|
@gziolo Thanks for the heads up! I'll take a look at the drag gestures. |
|
@gziolo I just made an update for the drag gestures 🤞 |
gziolo
force-pushed
the
update/upgrade-dependencies-g2-components
branch
from
70558fa to
bf9f9e5
Compare
Member
Author
|
This PR removed 17kB from the bundle size
It looks like we are using two copies of Reakit. I opened ItsJonQ/g2#237 to address it on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: ItsJonQ/g2#233.
This PR tries to update dependencies shared with G2 components to their latest versions.
{ "@emotion/core": "10.1.1", "downshift": "6.0.15", "react-resize-aware": "3.1.0", "react-use-gesture": "9.0.0", "rtlcss": "2.6.2", "tinycolor2": "1.4.2", }The idea is that we use the same versions in
@wp-g2/*packages so we don't use 2 copies of the same packages in Gutenberg.How has this been tested?
I'm waiting for CI to verify if there are any breaking changes. I hope there none :)
Types of changes
Checklist: