Skip to content

Contact Info Inner Blocks -- UI Tests #28606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
illusaen wants to merge 1 commit into from
Closed

Contact Info Inner Blocks -- UI Tests #28606

illusaen wants to merge 1 commit into from

Conversation

@illusaen
Copy link
Contributor

@illusaen illusaen commented Jan 29, 2021 •
edited
Loading

NOTE: Will NOT be merged until #3001 is merged because UI tests run in release and cannot see dev blocks.

See #3064 for issue this is testing for. Related PR: #28569

gutenberg-mobile: #3072

Description

Adding UI test to ensure that inner blocks for contact info are rendered.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@illusaen illusaen mentioned this pull request Jan 29, 2021
Open
2 tasks
@guarani guarani self-requested a review February 19, 2021 13:00
guarani
guarani reviewed Feb 19, 2021
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests! ❤️ Left a comment above.

packages/react-native-editor/__device-tests__/pages/editor-page.js
Comment on lines +580 to +590
address: 'Address',
columns: 'Columns',
contactInfo: 'Contact Info',
cover: 'Cover',
email: 'Email Address',
heading: 'Heading',
image: 'Image',
latestPosts: 'Latest Posts',
list: 'List',
more: 'More',
phone: 'Phone Number',
Copy link
Contributor

@guarani guarani Feb 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could these changes which appear Jetpack-specific be moved to gutenberg-mobile?

Base automatically changed from master to trunk March 1, 2021 15:45
@annezazu annezazu added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Aug 31, 2021
@illusaen illusaen closed this by deleting the head repository Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guarani guarani guarani left review comments

Assignees

No one assigned

Labels

Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@illusaen @guarani @annezazu