Try updating composer packages #28623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
[Type] Task
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
Contributor
|
I think I saw a similar set of errors where I had to update |
Contributor
Author
|
PHP Unit Tests seem to be running now 🎉 I had to update phpunit to v8.5. Not sure if there are any known issues with that. However there are what look like some legit test failures. Not sure if these snuck in while tests weren't running on CI: |
This was referenced Feb 1, 2021
oandregal
force-pushed
the
try/updating-composer-packages
branch
from
852bde5 to
cd501d7
Compare
Member
|
Hey, I've landed a fix for the legacy settings failures #28628 and other minor things #28629 Rebased this PR with current This is how I've tested:
With the latest changes, it shouldn't report any errors. |
Contributor
|
Thanks all! Once we've got PHP unit tests back up again, should we maybe promote them to 'Required' in GitHub Actions? |
oandregal
approved these changes
Feb 1, 2021
Member
oandregal
left a comment
oandregal
left a comment
There was a problem hiding this comment.
This fixes the PHP issues we're having, which are quite disruptive to the workflow, so I'm going to go ahead and merge it. I still see some e2e failures, but they are unrelated to this PR.
Contributor
Author
|
Great stuff, thanks @nosolosw! |
noisysocks
pushed a commit
that referenced
this pull request
Feb 8, 2021
noisysocks
pushed a commit
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PHP unit tests are failing at the moment, as our docker images now use PHP 8 (https://github.com/docker-library/wordpress/pull/551/files). This PR updates composer packages to those compatible with PHP 8.