-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Interim fix for Latest Posts focus on load #28660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
mcsf
approved these changes
Feb 2, 2021
Contributor
mcsf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as interim fixes, go, this one is very straightforward, clear, and seems like a trade-off we can make until we approve a solution like #28658. 👍
noisysocks
pushed a commit
that referenced
this pull request
Feb 7, 2021
noisysocks
pushed a commit
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Latest Posts
Affects the Latest Posts Block
[Type] Bug
An existing feature does not function as intended
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #28417
Fixes: #28536
The above issues' problem is that
Latest Postsblock is not selectable and block settings will not display, after the page/post's load. It still works when inserting it for the first time..This PR is an interim fix for focus handling in
Latest Postsblock. The description of the root problem and the proper fix is in this PR: #28658, which I don't believe it will be soon ready - anyone of course that wants to chime in there is really welcome.I'm not sure if it's acceptable to merge this and then work on the proper
useEventsHandlerrefactor later, but with this PR with have this option.. 🤔