Skip to content

Load page templates via theme.json abstractions #28700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oandregal merged 7 commits into from
Feb 5, 2021
Merged

Load page templates via theme.json abstractions #28700

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
14e4f7c
Add pageTemplates field and getter
oandregal Feb 3, 2021
c80fbcc
Makes WP_Theme_JSON_Resolver->get_theme_data public
oandregal Feb 3, 2021
89ccea6
Make use of new methods in page-templates.php
oandregal Feb 3, 2021
6a7430b
Load classes
oandregal Feb 4, 2021
8545024
Add unit test for page templates
oandregal Feb 4, 2021
acf1543
composer format
Addison-Stavlo Feb 4, 2021
469cb6c
Make $theme static
oandregal Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit test for page templates
  • Loading branch information
@oandregal
oandregal committed Feb 5, 2021
commit 854502457aa48ee9edb7af59a16cfa736b53460d
18 changes: 18 additions & 0 deletions phpunit/class-wp-theme-json-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,4 +736,22 @@ function test_remove_insecure_properties_removes_unsafe_preset_settings() {
);
$this->assertEqualSetsWithIndex( $expected, $result );
}

function test_get_page_templates() {
$theme_json = new WP_Theme_JSON( array(
'pageTemplates' => array(
'page-home' => array(
'title' => 'Some title'
),
),
) );

$page_templates = $theme_json->get_page_templates();

$this->assertEqualSetsWithIndex( $page_templates, array(
'page-home' => array(
'title' => 'Some title',
),
) );
}
}