Skip to content

Add eslint rule for preventing string literals in select/dispatch/useDispatch #28726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gziolo merged 10 commits into from
Feb 9, 2021
Merged

Add eslint rule for preventing string literals in select/dispatch/useDispatch #28726

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4e711f2
Add rule
david-szabo97 Feb 4, 2021
643d5c4
Add rules for controls.select/dispatch and registry.select/dispatch
david-szabo97 Feb 5, 2021
ca1cea1
Create rule and add as warning
david-szabo97 Feb 5, 2021
a84b02b
Rework logic
david-szabo97 Feb 5, 2021
c19356a
Fix TypeError
david-szabo97 Feb 5, 2021
7b86a65
Add tests
david-szabo97 Feb 9, 2021
ae672af
Rename variables
david-szabo97 Feb 9, 2021
440cd57
Update comment
david-szabo97 Feb 9, 2021
56cde4b
Docs: Document the new ESLint rule added
gziolo Feb 9, 2021
98d0fa1
Rename and change error message
david-szabo97 Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename variables
  • Loading branch information
@david-szabo97
david-szabo97 committed Feb 9, 2021
commit ae672af9879c278b307b21be3dfbf4951f4851e0
22 changes: 12 additions & 10 deletions packages/eslint-plugin/rules/no-store-string-literals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ function getReferences( context, specifiers ) {
return references;
}

function collectAllNodesFromHocFunctions( context, node ) {
const hocSpecifiers = node.specifiers.filter(
function collectAllNodesFromCallbackFunctions( context, node ) {
const functionSpecifiers = node.specifiers.filter(
( specifier ) =>
specifier.imported &&
[
Expand All @@ -22,9 +22,9 @@ function collectAllNodesFromHocFunctions( context, node ) {
'withDispatch',
].includes( specifier.imported.name )
);
const hocReferences = getReferences( context, hocSpecifiers );
const functionReferences = getReferences( context, functionSpecifiers );

const hocFunctionVariables = hocReferences.reduce(
const functionArgumentVariables = functionReferences.reduce(
( acc, { identifier: { parent } } ) =>
parent && parent.arguments && parent.arguments.length > 0
? acc.concat(
Expand All @@ -33,11 +33,11 @@ function collectAllNodesFromHocFunctions( context, node ) {
: acc,
[]
);
const hocFunctionReferences = hocFunctionVariables.reduce(
const functionArgumentReferences = functionArgumentVariables.reduce(
( acc, variable ) => acc.concat( variable.references ),
[]
);
const possibleCallExpressionNodes = hocFunctionReferences
const possibleCallExpressionNodes = functionArgumentReferences
.filter( ( reference ) => reference.identifier.parent )
.map( ( reference ) => reference.identifier.parent );

Expand Down Expand Up @@ -100,7 +100,7 @@ module.exports = {
return;
}

const hocFunctionNodes = collectAllNodesFromHocFunctions(
const callbackFunctionNodes = collectAllNodesFromCallbackFunctions(
context,
node
);
Expand All @@ -113,9 +113,11 @@ module.exports = {
node
);

const allNodes = hocFunctionNodes
.concat( directNodes )
.concat( objectPropertyCallNodes );
const allNodes = [
...callbackFunctionNodes,
...directNodes,
...objectPropertyCallNodes,
];
allNodes
.filter(
( callNode ) =>
Expand Down