Iterate on the public API of WP_Theme_JSON_Resolver #28855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
requested review from
TimothyBJacobs and
spacedmonkey
as code owners
oandregal
added
[Type] Code Quality
|
Size Change: 0 B Total Size: 1.37 MB ℹ️ View Unchanged
|
6 tasks
Member
Author
|
I've rebased this branch from |
oandregal
force-pushed
the
update/theme-json-resolver
branch
from
fa72084 to
144ccae
Compare
aristath
approved these changes
Feb 10, 2021
Member
aristath
left a comment
aristath
left a comment
There was a problem hiding this comment.
Tested and confirmed nothing breaks. Code is clean and an improvement over what we previously had.
This looks good to me 👍
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #28700
This PR iterates on the public API of the
WP_Theme_JSON_Resolverclass. This is the whole API after the changes in this PR (all methods are static):get_core_data=> returns core data as it is in the core's theme.json file.get_theme_data=> returns theme data as it is in the theme.json file.get_user_data=> returns user data as it is in the database (custom post type).get_merged_data( $theme_data, $origin )=> returns the merged data atregister_user_custom_post_type=> register the CPT to store user's dataget_user_custom_post_type_id=> returns the ID of the user CPTtheme_has_support=> whether the current theme has support fortheme.jsonFollow-ups:
locate_templateby our own method Add an 'area' term for Template Parts. #28410 (comment)