Skip to content

Conversation

@fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Feb 9, 2021

Includes the changes from "Update lock file format version to version 2 (NPM 7)" PR.

Description

Appium dependency has included recently a fix for preventing an error when using NPM version 7 so it would be nice to update it.

How has this been tested?

Appium is used for running the end-to-end tests on the mobile version of the editor so for verifying that this is working it will require to run them.

Screenshots

N/A

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.

@fluiddot fluiddot added the [Type] Build Tooling Issues or PRs related to build tooling label Feb 9, 2021
@ockham
Copy link
Contributor

ockham commented Feb 9, 2021

Thanks! I was thinking we might be able to de-risk the npm 7 upgrade by getting the Appium upgrade in first? I.e. use npm 6 to upgrade Appium, and only then perform the npm 7 upgrade? Just in case we need to e.g. revert the npm 7 upgrade.

(Or maybe I'm overthinking it 😅 )

@fluiddot
Copy link
Contributor Author

fluiddot commented Feb 9, 2021

Thanks! I was thinking we might be able to de-risk the npm 7 upgrade by getting the Appium upgrade in first? I.e. use npm 6 to upgrade Appium, and only then perform the npm 7 upgrade? Just in case we need to e.g. revert the npm 7 upgrade.

(Or maybe I'm overthinking it 😅 )

Yeah, good idea, actually I'm preparing a PR for updating this dependency for NPM version 6 better.

@fluiddot fluiddot changed the title Update Appium dependency version to 1.20.2 Update Appium dependency version to 1.20.2 (NPM 7) Feb 9, 2021
@fluiddot
Copy link
Contributor Author

fluiddot commented Feb 9, 2021

I've created a PR with the update for NPM version 6. I'm going to close this PR since it won't be required.

@fluiddot fluiddot closed this Feb 9, 2021
@fluiddot fluiddot deleted the update/appium-1.20.2 branch February 9, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Build Tooling Issues or PRs related to build tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants