Revert "Blocks: Ensure that metadata registered on the server for core block is preserved on the client" #29279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
approved these changes
Feb 24, 2021
Contributor
glendaviesnz
left a comment
glendaviesnz
left a comment
There was a problem hiding this comment.
This fixed the issue we were seeing.
Before:
All blocks were wrapped in an extra div in - see below image figure has a div wrapper added
After:
Image div figure is now at top level of root container:
Contributor
Author
|
Nice sleuthing @glendaviesnz! We'll be sure to add a test case for this if we make a second attempt. Seems quite curious that this behavior pops up, when we stop loading definitions twice. |
|
Size Change: -7 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
7 tasks
glendaviesnz
deleted the
revert-29213-update/register-block-server-metadata
branch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #29213
#29213 was attempting to resolve an issue where metadata registered on the server from block.json would get overridden by the same data registered again on the client. Behavior here suggests that we may need to verify that the server metadata is returning what we expect.