[RNMobile] Fix missing context prop in BlockEdit component #29479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
[Type] Bug
2 tasks
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
7 tasks
cameronvoell
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3208Description
In the native version of the
BlockEditcomponent thecontextprop is not being passed to the edit component of the block so the context is not available if theusesContextproperty was set in the block's metadata.Based on the web version implementation, I added the logic related to fetching and passing the block context to the edit component of a block.
How has this been tested?
We don't have any block that has the
usesContextproperty in the metadata except thecore/social-linkblock. However although this block is registered, it's marked as a hidden block and it's only used as an inner block ofcore/social-linkswhich already passes its own block context.Being that said, testing this PR requires to introduce some code changes:
contextto the props list in the edit component of the paragraph block.console.log( context );in the component function.postIdandpostType, for regular post it should print{postId: 1, postType: "post"}.Screenshots
N/A
Types of changes
Bug fix
Checklist: