update "requires at least" value to 5.6

[bph]

of plugin file.

Description

For plugin, the minimum requirement is 5.5 - it's already updated in the readme.txt but not in the plugin header of gutenberg.php

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• I've tested my changes with keyboard and screen readers.
• My code has proper inline documentation.
• I've included developer documentation if appropriate.
• I've updated all React Native files affected by any refactorings/renamings in this PR.

[ntsekouras]

It's 5.6 now :) - #29701

[gziolo]

I think it should be 5.6 now after @youknowriad merged #29701 😄

[youknowriad]

Do you think we can remove this entirely from here? I mean we already have this value defined in readme.txt isn't that enough?

[swissspidy]

I think we should keep them. See https://core.trac.wordpress.org/ticket/46938

[swissspidy]

Could add Tested up to here too, fwiw

[gziolo]

See the last comment from @SergeyBiryukov:

If the headers are defined in both readme.txt and the main plugin file, precedence is given to the plugin file.

[SergeyBiryukov]

Do you think we can remove this entirely from here? I mean we already have this value defined in readme.txt isn't that enough?

Just noting that WordPress 5.8 aims to remove parsing readme.txt files from validate_plugin_requirements(), see https://core.trac.wordpress.org/ticket/48520. Per discussion with Otto, apparently that file should only have been used for the Plugin Directory and not for core, which should retrieve the data it needs from the main plugin file instead.

So I would suggest removing the Requires at least and Requires PHP headers from the readme.txt file, and keeping them only in the main plugin file. The Plugin Directory supports that too, see https://meta.trac.wordpress.org/ticket/4514.

[gziolo]

Thanks for clarifying. I will make sure we update @wordpress/create-block and its templates to follow the same approach.

[bph]

Wasn't fast enough 🤣😂 @youknowriad took care of it. 👍🦄Thanks for all the comments.

[youknowriad]

@bph we actually stiil need to do that if you want to give it a try. I wasn't aware of the flags in the php file personally #29646 (comment)

[bph]

Oh, sorry. Yes, I can update to 5.6. Hang-on

[youknowriad]

@bph can you also remove the two headers from the readme.txt to avoid duplication?

[bph]

Updated @youknowriad -

[youknowriad]

Looks like this PR needs a rebase now (conflict with the readme update on trunk). So you can do something like git fetch origin && git rebase origin trunk and follow the instructions.

[bph]

Should be fixed now @youknowriad -- it still shows a conflict?

[youknowriad]

@bph I can take care of it.

[youknowriad]

Looks we have some issues with wp-env at the moment, I'll merge this after we solve these.