[RNMobile] Partial fix splitting & merging Paragraph/Heading issue in ReactAztec Android #29654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jd-alexander
added
the
Mobile App - i.e. Android or iOS
Contributor
Author
|
@cameronvoell @geriux I am just sharing this WIP PR, I used to explore this issue. Let me know if the fix I am trying gives you any ideas. |
2 tasks
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
Contributor
|
FWIW, I'm having a look at the issue as well. I have the impression that the selection change event that gets received after the |
7 tasks
Contributor
Author
|
Closing this PR since #29683 has a more optimal solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29478
Gutenberg Mobile wordpress-mobile/gutenberg-mobile#3233
Description
This solution resolves a bug with the splitting/merging behavior of the Paragraph/Heading block.
There are currently two mechanisms for processing enter events within the
ReactAztecTextcomponent.KeyListeneris utilized to listen to key presses that are triggered from a physical keyboard. - The editor behaves as expected.EnterPressedWatcherthat observes text changes that occur as a result of the soft keyboard. - The editor does not behave as expected.Currently, within the editor, once the user moves the cursor within the content a selection change event is triggered as the
selectionStartandselectionEndproperties are modified and the content changes are processed as a result.The Problem
There are several events are created when the editor notifies listeners of
onEnter,onBackspace,onPasteetc. actions.In the case of this bug, the editor has created two events instead of one. First the
onEnterevent is triggered and then thepropagateSelectionChanges. I think then when thepropagateSelectionChangesevent is triggered, it is overwriting the content that was appropriately processed by theonEnterevent, thus putting theRichTextcomponent in an inconsistent state.The Partial Solution
The solution I came up with, was to dedicate a flag specifically to toggling the
propagateSelectionChangesduring the execution of theonEnterfunction. I could have utilized theshouldHandleOnSelectionChangebut I decided not to as I wanted to use a flag that would be specific to the issue in case it can be refactored later.During testing, I sometimes end up with the bug. I think it's as a result of a selection change bypassing the flag. This will require more investigation. I might try disabling the listener depending on if text watchers are processed before selection change events.
How has this been tested?
Screenshots
editor.mp4
Checklist: