Skip to content

[RNMobile] Image Block: Improve Text Entry for Long Alt Text #29670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hypest merged 30 commits into from
Apr 2, 2021
Merged

[RNMobile] Image Block: Improve Text Entry for Long Alt Text #29670

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d5b7811
Create new AltTextSettings component
SiobhyB Mar 9, 2021
a445c7e
Update text colour in footer note in styles.css
SiobhyB Mar 9, 2021
489c402
Increase min-height of altTextEditor
SiobhyB Mar 10, 2021
8c6a25b
Update border colours for both light and dark mode
SiobhyB Mar 10, 2021
1ca59bd
Update text colour in dark mode
SiobhyB Mar 10, 2021
f93c120
Update footer note styling in styles.css
SiobhyB Mar 10, 2021
0f3019d
Set max height for the editor
SiobhyB Mar 10, 2021
0286cbd
Increase bottom padding of footer note
SiobhyB Mar 10, 2021
23de16b
Update colour of placeholder text
SiobhyB Mar 10, 2021
ff711fa
Styling tweaks to footnote and placeholder text
SiobhyB Mar 10, 2021
d626c14
Update font-size of footnote
SiobhyB Mar 11, 2021
1642f47
Set defined height for altTextEditor
SiobhyB Mar 11, 2021
e876fbf
Update blue colour of link for both light and dark mode
SiobhyB Mar 11, 2021
fc92cc4
Update CHANGELOG.md
SiobhyB Mar 11, 2021
01b42fa
Convert "AltTextSettings" component into more generic "BottomSheetTex…
SiobhyB Mar 16, 2021
2531784
Created README.md for BottomSheetTextControl component
SiobhyB Mar 16, 2021
7afa119
Formatting tweaks for README.md
SiobhyB Mar 16, 2021
c9a9282
Formatting tweaks for README.md
SiobhyB Mar 16, 2021
a3a0b5b
retrigger checks
SiobhyB Mar 16, 2021
886f49a
Simplify BottomSheetTextControl
SiobhyB Mar 18, 2021
2d0497d
Merge branch 'trunk' into update/text-entry-for-alt-text-field
SiobhyB Mar 18, 2021
edaa2ad
retrigger checks
SiobhyB Mar 18, 2021
265b989
Correct merge conflict
SiobhyB Mar 18, 2021
6d80346
Update "SmallFooterMessageLinkControl" to "FooterMessageLink"
SiobhyB Mar 25, 2021
be400ce
Update "SmallFooterMessageLinkControl" to "FooterMessageLink"
SiobhyB Mar 25, 2021
cb88abf
Delete small-footer-message-control-link.native.js
SiobhyB Mar 25, 2021
bb7c8a9
Remove small-footer-message-control
SiobhyB Mar 25, 2021
db5f3f6
Update Footer Message Control
SiobhyB Mar 25, 2021
6b7ccf5
Add README to FooterMessageLink component
SiobhyB Mar 29, 2021
3758cb0
Revert accidental commit
SiobhyB Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Increase min-height of altTextEditor 
This commit increases the min-height of "altTextEditor" so that the editor is a larger height on iOS devices by default.
  • Loading branch information
@SiobhyB
SiobhyB committed Mar 10, 2021
commit 489c40292f7f5f7f24a8f0c1f0aacbe6d583ac90
2 changes: 1 addition & 1 deletion packages/components/src/mobile/alt-text-settings/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const AltTextSettings = ( { alt, updateAlt } ) => {
value={ value }
multiline={ true }
placeholder={ __( 'Add alt text' ) }
numberOfLines={ 4 }
style={ styles.altTextEditor }
/>
</PanelBody>

Expand Down
5 changes: 5 additions & 0 deletions packages/components/src/mobile/alt-text-settings/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
border-right-width: 0;
}

.altTextEditor {
padding: 14px 0;
min-height: 80px;
}

.altTextFootnote {
color: $gray-text-min;
text-align: left;
Expand Down