Add theme styles in the site editor #29704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oandregal
commented
Mar 10, 2021
oandregal
added
[Feature] Custom Editor Styles
|
Size Change: +14 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
- if the theme has declared support - if the theme doesn't have any editor styles
scruffian
reviewed
Mar 10, 2021
| wp_enqueue_style( 'wp-format-library' ); | ||
|
|
||
| if ( | ||
| current_theme_supports( 'wp-block-styles' ) || |
Contributor
There was a problem hiding this comment.
We have this same condition for loading the styles in the post editor. I wonder if we should refactor that to share the code?
Contributor
There was a problem hiding this comment.
If we do refactor this I see a function in WP_Theme_Config being introduce here #29667
scruffian
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we don't enqueue the theme styles in the site editor, but we do in the widgets and post editors. As a result, there're some things that appear broken, such as that a group block with background color doesn't get padding.
This PR enqueues this stylesheet to the site editor as well.
How to test
The expected result is that the group block gains some padding.