Block navigation with keydown #2979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'm not sure if this is the best approach. We may want to keep the keyup handling in there, and just fire movement on subsequent keydowns using the previous shouldMove state value. Thoughts? |
Member
|
This reverts 961c92c. @youknowriad Do you remember why it was done this way? |
Contributor
|
Because of this #2894 (comment) |
Contributor
|
I can't seem to reproduce the original issue I had with |
Member
|
Going to work further here: #2296. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed keyup handling for writing-flow and made keydown navigate blocks
How Has This Been Tested?
I have manually tested this, but not exhaustively
Screenshots (jpeg or gifs if applicable):
Types of changes
Cross between a bug fix and a new feature
Checklist: