Skip to content

Components: Replace Button with ui/Button using deprecated props strategy #29990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarayourfriend wants to merge 6 commits into from
Closed

Components: Replace Button with ui/Button using deprecated props strategy #29990

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
93806bb
Components: Replace Button with ui/Button using deprecated props stra…
sarayourfriend Mar 18, 2021
4c28d32
Remove deprecation warning for icon as string
sarayourfriend Mar 18, 2021
238dc67
Handle isPressed correctly
sarayourfriend Mar 18, 2021
457ab0f
Expand button Dashicon comment explanation
sarayourfriend Mar 18, 2021
fd63d2d
Upgrade G2
sarayourfriend Mar 18, 2021
50ff05e
Use correct next button and fix pressed styles
sarayourfriend Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Expand button Dashicon comment explanation
  • Loading branch information
@sarayourfriend
sarayourfriend committed Mar 18, 2021
commit 457ab0ffb42d8fa9496dbece7f8e0e8c8b76c8df
2 changes: 1 addition & 1 deletion packages/components/src/button/use-deprecated-button-props.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ function getIsLoading( { isBusy, isLoading } ) {

function getIcon( { icon } ) {
if ( typeof icon === 'string' ) {
// We can't deprecate this strategy because block authors depend on it
// We can't deprecate this strategy because block authors depend on it but the new component is ignorant of Dashicon
return <Dashicon icon={ icon } />;
}
return icon;
Expand Down