Components: Upgrade new component system #30146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
7 tasks
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
|
@sarayourfriend Great! Taking it for a spin now |
|
Ooooh boy. Specificity fighting 👊 . Screenshot from Gutenberg (Block with Typography controls)
There are a bunch of global
In other words, we run into the same issues we had previously. Previously, the solution was to add The new Component System does this by default to the power of 7. At the end of the day... I think we're going to have specificity fighting.
In the case of this Relying on auto-compounding feels much better, but its a trickier thing to manage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the G2 libraries
How has this been tested?
Test that compounding specificity is gone (open storybook for example and visit one of the G2 components, inspect it and verify that it doesn't have compounding specificity in it's style rules).
Types of changes
Upgrading dependency.
Checklist: