RichText: fix arrow navigation around emoji #30206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
ellatrix
requested review from
ajitbohra,
cameronvoell,
guarani,
nerrad and
ntwb
as code owners
|
Size Change: -1.43 kB (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
ellatrix
changed the title
Member
Author
|
This tests well and all rich text e2e tests are passing. |
Member
|
Thanks, @ellatrix 🍓 |
Member
Author
|
@mkaz Just curious, what is #30206 (reference)? |
Member
|
@ellatrix I don't know what happened or why the two PRs are still referenced together. I messed up the rebase on my PR, but fixed it up. All the other commits got cleaned up except this one got intermingled, but shows no diff, with this merged I'll remove it from the other PR. |
Member
Author
|
Ah, ok :) Was just wonder how it got to: "This commit does not belong to any branch on this repository." |
mcsf
added
the
[Feature] Writing Flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #27202.
The problem is that we're handling (simple) arrow key navigation ourselves. We should only handle it when navigating around format boundaries and otherwise let the browser do its thing.
How has this been tested?
See #27202.
Screenshots
Types of changes
Checklist: