Components: Replace Flex with ui/Flex and deprecate isReversed #30295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +1.41 kB (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flexwith the new component systemFlex.isReversedin favor of the more powerfuldirectionprop.Potentially an alternative to #30261
How has this been tested?
Run Gutenberg and test especially the cover block and its controls as it makes heavy usage of the Flex component. Test the box control, the angle picker control, the gradient controls.
Also test card in Storybook (
npm run storybook:dev) by going to/iframe.html?id=components-card--default&knob-Example%3A Width=360px&knob-Card%3A isBorderless=true&knob-Card%3A size=medium&knob-Header%3A children=Content&knob-Card%3A isElevated=true&viewMode=storyScreenshots
Types of changes
Non-breaking change, new feature, deprecating a prop.
Checklist:
*.native.jsfiles for terms that need renaming or removal).