Add Cover block replace media e2e test #30306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Block] Cover
7 tasks
|
Size Change: +24 B (0%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
dcalhoun
changed the title
Ensure only one modal is presented at a time, as this is required by react-native-modal for iOS.
Member
Author
|
@geriux would you be willing to review the approach for these Cover block edit tests? Please feel free to reach out if you have any questions. Thanks! |
geriux
approved these changes
Apr 8, 2021
Member
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding this! Tested it on iOS. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add native e2e test for replacing Cover block media. Testing this for iOS on a device is valuable to ensure that it properly handles opening multiple modals, as only one can be open at a time. Sibling to #30270.
How has this been tested?
npm run native test:e2e:ios:localScreenshots
n/a
Types of changes
Automated tests
Checklist:
*.native.jsfiles for terms that need renaming or removal).