Skip to content

BoxControl: Allow configurable sides #30606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 6 commits into from
Apr 19, 2021
Merged

BoxControl: Allow configurable sides #30606

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0a0f0b9
Modify BoxControl to allow configurable sides
aaronrobertshaw Apr 8, 2021
8921929
Fix box control reset button in global styles sidebar
aaronrobertshaw Apr 8, 2021
add9b4d
Switch sides configuration to use array
aaronrobertshaw Apr 9, 2021
d3be5d6
Change box control reset to use supplied reset values
aaronrobertshaw Apr 9, 2021
0788359
Treat empty array as undefined for sides config
aaronrobertshaw Apr 19, 2021
123b241
Only offer unlink button when multiple sides allowed
aaronrobertshaw Apr 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Only offer unlink button when multiple sides allowed
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed Apr 19, 2021
commit 123b241c9f9836a49bf6f45d9029e30380abad70
17 changes: 10 additions & 7 deletions packages/components/src/box-control/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,11 @@ export default function BoxControl( {
} );
const inputValues = values || DEFAULT_VALUES;
const hasInitialValue = isValuesDefined( valuesProp );
const hasOneSide = sides?.length === 1;

const [ isDirty, setIsDirty ] = useState( hasInitialValue );
const [ isLinked, setIsLinked ] = useState(
! hasInitialValue || ! isValuesMixed( inputValues )
! hasInitialValue || ! isValuesMixed( inputValues ) || hasOneSide
);

const [ side, setSide ] = useState( isLinked ? 'all' : 'top' );
Expand Down Expand Up @@ -146,12 +147,14 @@ export default function BoxControl( {
/>
</FlexBlock>
) }
<FlexItem>
<LinkedButton
onClick={ toggleLinked }
isLinked={ isLinked }
/>
</FlexItem>
{ ! hasOneSide && (
<FlexItem>
<LinkedButton
onClick={ toggleLinked }
isLinked={ isLinked }
/>
</FlexItem>
) }
</HeaderControlWrapper>
{ ! isLinked && <InputControls { ...inputControlProps } /> }
</Root>
Expand Down