Skip to content

Pullquote: add block support #30951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 12 commits into from
Jul 20, 2021
Merged

Pullquote: add block support #30951

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
aed3003
initial commit
ramonjd Apr 12, 2021
1e806be
Updating fixtures and deprecated fixtures.
ramonjd Apr 12, 2021
c998b6f
Removed block attributes from block.json that block supports injects
ramonjd Apr 14, 2021
681b057
Renaming and updating deprecation v4 colors to reflect the usage of c…
ramonjd Apr 20, 2021
7dd4656
Implementing code change suggestions in deprecated.js
ramonjd Apr 20, 2021
cb7322e
This commit ensures that we're setting the style attribute required f…
ramonjd Apr 20, 2021
f1b9240
Regenerating fixtures after the trim fix in https://github.com/WordPr…
ramonjd Apr 21, 2021
40ddfc1
Ensure that child elements inherit their colors from the figure element
ramonjd Apr 23, 2021
9f2eca6
All deprecation migration functions, where their corresponding save f…
ramonjd Apr 23, 2021
6a5d751
Since we've introduced block support for border and background color,…
ramonjd Apr 27, 2021
6d3491d
Regenerating main color deprecation fixtures after #33502
ramonjd Jul 20, 2021
db08851
Fix after rebase
ramonjd Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Regenerating fixtures after the trim fix in #30981
  • Loading branch information
@ramonjd
ramonjd committed Jul 20, 2021
commit f1b924003cc450ead94b67c9b6e2d2d2fe2554ac
9 changes: 0 additions & 9 deletions packages/e2e-tests/fixtures/blocks/core__pullquote__custom-colors.parsed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,5 @@
"innerContent": [
"\n<figure class=\"wp-block-pullquote is-style-default has-border-color has-text-color has-background\" style=\"background-color:#3486aa;border-color:#045679;color:#ffefef\"><blockquote><p>pullquote</p><cite>citation</cite></blockquote></figure>\n"
]
},
{
"blockName": null,
"attrs": {},
"innerBlocks": [],
"innerHTML": "\n",
"innerContent": [
"\n"
]
}
]
7 changes: 0 additions & 7 deletions packages/e2e-tests/fixtures/blocks/core__pullquote__custom-colors__deprecated-4.parsed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,5 @@
"innerContent": [
"\n<figure class=\"wp-block-pullquote has-background is-style-default\" style=\"border-color:#2207d0\"><blockquote class=\"has-text-color has-subtle-background-color\"><p>Pullquote custom color</p><cite>my citation</cite></blockquote></figure>\n"
]
},
{
"blockName": null,
"attrs": {},
"innerBlocks": [],
"innerHTML": "\n",
"innerContent": [ "\n" ]
}
]
2 changes: 1 addition & 1 deletion ...es/e2e-tests/fixtures/blocks/core__pullquote__custom-colors__deprecated-4.serialized.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<!-- wp:pullquote {"textColor":"subtle-background","className":"has-background is-style-default","style":{"border":{"color":"#2207d0"}}} -->
<!-- wp:pullquote {"className":"has-background is-style-default","textColor":"subtle-background","style":{"border":{"color":"#2207d0"}}} -->
<figure class="wp-block-pullquote has-background is-style-default has-border-color has-subtle-background-color has-text-color" style="border-color:#2207d0"><blockquote><p>Pullquote custom color</p><cite>my citation</cite></blockquote></figure>
<!-- /wp:pullquote -->
9 changes: 0 additions & 9 deletions packages/e2e-tests/fixtures/blocks/core__pullquote__deprecated-4.parsed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,5 @@
"innerContent": [
"\n<figure class=\"wp-block-pullquote has-background has-black-background-color is-style-solid-color\"><blockquote class=\"has-text-color has-white-color\"><p>pullquote</p><cite>before block supports</cite></blockquote></figure>\n"
]
},
{
"blockName": null,
"attrs": {},
"innerBlocks": [],
"innerHTML": "\n",
"innerContent": [
"\n"
]
}
]
2 changes: 1 addition & 1 deletion packages/e2e-tests/fixtures/blocks/core__pullquote__deprecated-4.serialized.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<!-- wp:pullquote {"textColor":"white","className":"has-background has-black-background-color is-style-solid-color","backgroundColor":"black","style":{}} -->
<!-- wp:pullquote {"className":"has-background has-black-background-color is-style-solid-color","backgroundColor":"black","textColor":"white","style":{}} -->
<figure class="wp-block-pullquote has-background has-black-background-color is-style-solid-color has-white-color has-black-background-color has-text-color has-background"><blockquote><p>pullquote</p><cite>before block supports</cite></blockquote></figure>
<!-- /wp:pullquote -->