Skip to content

[RNMobile] Add Featured Banner to Image Block (iOS Only) #30957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SiobhyB wants to merge 75 commits into from
Closed

[RNMobile] Add Featured Banner to Image Block (iOS Only) #30957

Changes from 1 commit
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
a4a52fe
Add "set as featured image" button to image block
SiobhyB Feb 8, 2021
4040201
Add "setFeaturedImage" function in bridge code
SiobhyB Feb 11, 2021
6bcfbd9
Add setFeaturedImage function to MainApplication
SiobhyB Feb 12, 2021
0cff0d7
Add "OnSetFeaturedImageListener" listener
SiobhyB Feb 12, 2021
dbec57d
Update edit.native.js with small syntax correction
SiobhyB Feb 12, 2021
d66bd01
Set up "OnSetFeaturedImageListener" in WPAndroidGlue.java
SiobhyB Feb 12, 2021
d1ed155
Passing featured image ID from native (Android) to Gutenberg
SiobhyB Mar 3, 2021
6a57885
Merge branch 'trunk' into update/featured-image-button-in-image-block…
SiobhyB Mar 3, 2021
444f3e3
Restore missing curly brace
SiobhyB Mar 3, 2021
2cbe570
Updates to featured-banner.native.js
SiobhyB Mar 5, 2021
073fa92
Attempts to select featured image using getEditedPostAttribute()
SiobhyB Mar 15, 2021
64359b1
Update featured-banner.native.js
SiobhyB Mar 15, 2021
48f8ea1
Add featured banner to image/index.native.js
SiobhyB Mar 15, 2021
f114ade
Update featured image banner and button styles
SiobhyB Mar 15, 2021
46ba7e8
Create getFeaturedImageId function and cleanup
SiobhyB Mar 16, 2021
b8f05f4
Tidy up edit.native.js
SiobhyB Mar 16, 2021
c7d00f3
Update AndroidGlueCode
SiobhyB Mar 18, 2021
84a8850
retrigger checks
SiobhyB Mar 22, 2021
eb78dc4
Update setup.js
SiobhyB Mar 22, 2021
bed517e
retrigger checks
SiobhyB Mar 22, 2021
64b1c8b
Update function name from "featuredImageIdChange" to "featuredImageId…
SiobhyB Mar 23, 2021
d8c0824
Rename "featuredImageIdNotifier" to "onRequestFeaturedImageId"
SiobhyB Mar 23, 2021
32f134d
Create OnSetFeaturedImageListener
SiobhyB Mar 23, 2021
75de59f
Dismiss bottomsheet when "setFeaturedImage" is called
SiobhyB Mar 23, 2021
67369d3
Introduce "onRemoveFeatured" button and tidying up names
SiobhyB Mar 29, 2021
c9aba0a
Updates to function names
SiobhyB Mar 29, 2021
a9d051f
Convert FeaturedBanner to Badge component
SiobhyB Mar 30, 2021
a92525b
Update edit.native.js to correct merge conflict
SiobhyB Mar 30, 2021
54a5f14
Correct merge conflict with GutenbergBridgeJS2Parent.java
SiobhyB Mar 30, 2021
e99999c
retrigger checks
SiobhyB Mar 30, 2021
be31d63
retrigger checks
SiobhyB Mar 30, 2021
9795874
retrigger checks
SiobhyB Mar 30, 2021
2284524
retrigger checks
SiobhyB Mar 30, 2021
2736f33
Update edit.native.js to fix merge conflict
SiobhyB Mar 31, 2021
e9ebc69
Update edit.native.js to check if an image is featured uppn changes
SiobhyB Mar 31, 2021
2eb1979
Update styles.native.scss to add border to the top of featured button
SiobhyB Apr 1, 2021
a33b8b9
Update edit.native.js
SiobhyB Apr 1, 2021
0cdeadb
Introduce "featuredMedia" prop for use when editor loads
SiobhyB Apr 6, 2021
737627d
Fetch ID of post's initial featured image
SiobhyB Apr 7, 2021
9e524ea
Merge branch 'trunk' into update/featured-image-button-in-image-block…
SiobhyB Apr 8, 2021
6d53341
Updated featured state when image is replaced within block
SiobhyB Apr 8, 2021
cc00dc2
Remove checkIfFeaturedImage function
SiobhyB Apr 8, 2021
4dc6cef
Fix merge conflict
SiobhyB Apr 8, 2021
b335086
Fix merge conflict
SiobhyB Apr 8, 2021
3cbe30a
Add "setFeaturedImage" and "featuredImageIdCurrent" functions to Swif…
SiobhyB Apr 10, 2021
39303e4
Simplify this.state.isFeaturedImage by converting to a boolean inside…
SiobhyB Apr 10, 2021
0c69a62
Comment out iOS-specific changes to the bridge
SiobhyB Apr 12, 2021
cc4aa8d
Add iOS functions to bridge
SiobhyB Apr 12, 2021
d71d067
Flag featured image when editor mounts and comment out iOS methods fr…
SiobhyB Apr 12, 2021
28f19af
Comment out a bridge function for iOS (missing from previous commit).
SiobhyB Apr 12, 2021
262291f
Add set featured image functionality behind dev flag
SiobhyB Apr 13, 2021
a17e6e9
Move "set as featured" button behind devOnly and androidOnly flag
SiobhyB Apr 13, 2021
3277f6b
Remove redundant code
SiobhyB Apr 13, 2021
4a1825b
Remove import of android.util.Log
SiobhyB Apr 13, 2021
507e2b3
Update CHANGELOG.md
SiobhyB Apr 13, 2021
f4cd37d
Merge branch 'trunk' into add-featured-badge
SiobhyB Apr 13, 2021
001cd5d
Update Badge component for re-usability
SiobhyB Apr 13, 2021
154c66d
Merge branch 'add-featured-badge' of https://github.com/SiobhyB/guten…
SiobhyB Apr 13, 2021
c0ebd51
merge
SiobhyB Apr 13, 2021
37bc422
merge
SiobhyB Apr 13, 2021
9638208
Correct merge conflict
SiobhyB Apr 13, 2021
79f0a1e
Lift subscribeFeaturedImageIdCurrent from image/edit.native.js to pos…
SiobhyB Apr 14, 2021
3b0d6ee
Remove commented out functions from iOS bridge
SiobhyB Apr 14, 2021
ea5affb
Remove androidOnly const
SiobhyB Apr 14, 2021
5502856
Correct typo in README
SiobhyB Apr 14, 2021
4dc3248
Replace call to 'core' with 'coreStore"
SiobhyB Apr 14, 2021
494f298
Rename featuredMedia to featuredImageId
SiobhyB Apr 14, 2021
f420dde
Destructure props
SiobhyB Apr 14, 2021
ff15fbb
Rename "featuredImageIdCurrent" to "featuredImageIdNativeUpdated"
SiobhyB Apr 15, 2021
f520659
Limit subscribeFeaturedImageIdNativeUpdated to Android-only
SiobhyB Apr 15, 2021
4268e2d
Request a post's initial featured image ID via gutenbergFeaturedImage…
SiobhyB Apr 19, 2021
9884a64
Send featuredImageId as "initialProps"
SiobhyB Apr 19, 2021
7789f11
Add bridge methods for "featuredImageIdNativeUpdated"
SiobhyB Apr 19, 2021
98ba19d
retrigger checks
SiobhyB Apr 20, 2021
afb75e8
Merge branch 'trunk' into add-featured-badge-ios
SiobhyB Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix merge conflict
  • Loading branch information
@SiobhyB
SiobhyB committed Apr 8, 2021
commit 4dc6cef395c7d0b6bd59fb349729dce3be4a184a
7 changes: 4 additions & 3 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
/packages/create-block @gziolo @mkaz
/packages/create-block-tutorial-template @gziolo
/packages/custom-templated-path-webpack-plugin @ntwb @nerrad @ajitbohra
/packages/dependency-extraction-webpack-plugin @gziolo
/packages/docgen @nosolosw
/packages/e2e-test-utils @ntwb @nerrad @ajitbohra
/packages/e2e-tests @ntwb @nerrad @ajitbohra
Expand All @@ -63,9 +64,9 @@
/packages/library-export-default-webpack-plugin @ntwb @nerrad @ajitbohra
/packages/npm-package-json-lint-config @gziolo @ntwb @nerrad @ajitbohra
/packages/postcss-themes @ntwb @nerrad @ajitbohra
/packages/scripts @gziolo @ntwb @nerrad @ajitbohra
/packages/dependency-extraction-webpack-plugin @gziolo
/packages/prettier-config @ntwb @gziolo
/packages/scripts @gziolo @ntwb @nerrad @ajitbohra
/packages/stylelint-config @ntwb

# UI Components
/packages/components @ajitbohra @jaymanpandya @chrisvanpatten
Expand Down Expand Up @@ -127,4 +128,4 @@
*.ios.js @ghost
*.native.scss @ghost
*.android.scss @ghost
*.ios.scss @ghost
*.ios.scss @ghost