Use a darker frame for template mode and previews #31044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Enhancement
youknowriad
commented
Apr 21, 2021
| color: $white; | ||
| border-radius: 0; | ||
| height: $header-height; | ||
| height: $header-height + 1px; |
Contributor
Author
There was a problem hiding this comment.
This small hack is here to not show the light border under the toggle, especially in "preview" or "template mode"
Contributor
There was a problem hiding this comment.
You can use $border-width here, that returns 1px. Not because we need to change the contents of that variable very often, but it helps work sort of like a comment to explain what that pixel is for.
Contributor
There was a problem hiding this comment.
We should probably add a similar hack to "hide" the inspector border too.
|
Size Change: +469 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
Contributor
|
Looks good. @jameskoster what color is the border on the canvas in your mockups? Is it still the light gray used here?
|
Contributor
|
Personally I think the dark grey clashes with the color of the W button that takes you back to the dashboard. Back link: When the link is clicked, -active, the color is so dark that it is close to invisible. |
Contributor
|
When clicking the back link, chrome, windows. |
Contributor
Yes I've been using the same color we use for all borders which I believe is grey-300. It works well to distinguish the frame against a variety of different theme background colors:
Another option is to use elevation...
... which works better on the dark frame than the light one. But still presents other challenges. |
Contributor
Author
|
how is this looking? |
Contributor
|
I think it's good to go. |
jameskoster
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the latest designs, it seems we now want a darker frame for template mode and previews.