Skip to content

Block Support: Update border support to allow non-pixel units #31483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 8 commits into from
Jun 7, 2021
Merged

Block Support: Update border support to allow non-pixel units #31483

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
32c0597
Update border support to allow non-pixel units
aaronrobertshaw May 5, 2021
835ccc8
Fix button block application of border radius
aaronrobertshaw May 6, 2021
e6c1fcb
Prevent empty string being saved to border attributes
aaronrobertshaw May 6, 2021
85f35df
Handle border backwards compatibility for dynamic blocks
aaronrobertshaw May 6, 2021
5d7bb98
Fix search block to work with non-pixel border radius units
aaronrobertshaw May 6, 2021
111a75a
Update border support style tests for custom units
aaronrobertshaw May 10, 2021
81a3256
Remove extraneous cleanEmptyObject call
aaronrobertshaw Jun 7, 2021
41acd39
Add a11yLabels for border CSS Units
aaronrobertshaw Jun 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle border backwards compatibility for dynamic blocks
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed Jun 7, 2021
commit 85f35df2774f11854a715025e106a50266513545
16 changes: 14 additions & 2 deletions lib/block-supports/border.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,13 @@ function gutenberg_apply_border_support( $block_type, $block_attributes ) {
isset( $block_attributes['style']['border']['radius'] )
) {
$border_radius = $block_attributes['style']['border']['radius'];
$styles[] = sprintf( 'border-radius: %s;', $border_radius );

// This check handles original unitless implementation.
if ( is_numeric( $border_radius ) ) {
$border_radius .= 'px';
}

$styles[] = sprintf( 'border-radius: %s;', $border_radius );
}

// Border style.
Expand All @@ -75,7 +81,13 @@ function gutenberg_apply_border_support( $block_type, $block_attributes ) {
isset( $block_attributes['style']['border']['width'] )
) {
$border_width = $block_attributes['style']['border']['width'];
$styles[] = sprintf( 'border-width: %s;', $border_width );

// This check handles original unitless implementation.
if ( is_numeric( $border_width ) ) {
$border_width .= 'px';
}

$styles[] = sprintf( 'border-width: %s;', $border_width );
}

// Border color.
Expand Down