Skip to content

Button: deprecate isPrimary, isSecondary, isTertiary and isLink props in favour of variant prop #31713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ciampo merged 17 commits into from
May 26, 2021
Merged

Button: deprecate isPrimary, isSecondary, isTertiary and isLink props in favour of variant prop #31713

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
8082eeb
Deprecate isPrimary, isSecondary and isTertiary props in favor of var…
ciampo May 11, 2021
f1163ec
Update button docs
ciampo May 11, 2021
2d2e532
Update Button variant in Storybook
ciampo May 11, 2021
b744bc0
Update tests
ciampo May 11, 2021
856c632
changelog
ciampo May 11, 2021
67032a6
Swap order of isSecondary / isTertiary deprecation
ciampo May 11, 2021
ddf31eb
Depracate isLink prop too
ciampo May 11, 2021
a0ed04d
Spacing
ciampo May 11, 2021
4253926
Update changelog
ciampo May 11, 2021
a4601e0
Update example in README
ciampo May 11, 2021
130ad24
Add unit test for deprecated props
ciampo May 12, 2021
e6e0e5a
Use `expect( console ).toHaveWarned()` instead of mocking `@wordpress…
ciampo May 14, 2021
36ae2c6
Revert auto-formatting
ciampo May 14, 2021
9d7d2db
Move SCSS comment above selector
ciampo May 14, 2021
c030431
Do not mark isPrimary, isSecondary, isTertiary and isLink props as de…
ciampo May 14, 2021
973feec
Remove TODO comment
ciampo May 19, 2021
4bfd1d4
Better wording for the notice component README
ciampo May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update changelog
  • Loading branch information
@ciampo
ciampo committed May 26, 2021
commit 4253926b6baa884900a32e671c9d71f75fed99d8
2 changes: 1 addition & 1 deletion packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
### Deprecation

- `isReversed` prop in `Flex` component has been deprecated. Use `direction` instead ([#31297](https://github.com/WordPress/gutenberg/pull/31297)).
- `isPrimary`, `isSecondary` and `isTertiary` props in `Button` have been deprecated. Use `variant` instead ([#31713](https://github.com/WordPress/gutenberg/pull/31713)).
- `isPrimary`, `isSecondary`, `isTertiary` and `isLink` props in `Button` have been deprecated. Use `variant` instead ([#31713](https://github.com/WordPress/gutenberg/pull/31713)).

### Internal

Expand Down