Run Mocha on Webpack-generated bundle #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Why the move from |
Member
Author
|
|
Member
|
Ahh I see. I haven't tested it yet but I support the approach here. Can we merge #308 first? |
youknowriad
approved these changes
Mar 23, 2017
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
I suspect this to be a bit slower, but definitely better to have a unique build workflow
aduth
force-pushed
the
update/webpack-mocha
branch
from
8884d12 to
115f064
Compare
Member
Author
|
Rebased and found there was some issue with Chai plugins not being respected. Updated to reincorporate the bootstrap file, working well again. Will merge after CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing attempt to enable accurate testing on a Webpack-generated bundle (previously #289 (comment), #303, #301 (comment) ).
This pull request updates the Webpack configuration to create a separate testable bundle when
NODE_ENV=test. This allows us to test files which include loaders like thepegjs-loaderintroduced in #301.