Skip to content

Replace hardcoded CSS_UNITS and inherit values from theme.json #31822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 13 commits into from
May 19, 2021
Merged

Replace hardcoded CSS_UNITS and inherit values from theme.json #31822

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4638cc4
Move useCustomUnits
aristath May 13, 2021
a138589
refactor useCustomUnits
aristath May 13, 2021
79918f6
reorder units
aristath May 13, 2021
4dfed69
use layout.units
aristath May 13, 2021
241c175
useCustomUnits in columns
aristath May 13, 2021
313f989
useCustomUnits for cover
aristath May 13, 2021
09ba6b7
useCustomUnits for search
aristath May 13, 2021
6a15ab8
move inside the unit-control component
aristath May 13, 2021
439ad19
move to components & refactor
aristath May 14, 2021
20e17f1
update fontsize
aristath May 14, 2021
c8c8120
remove unstable/experimental units
aristath May 14, 2021
afa56ec
forgot about the native exports
aristath May 14, 2021
e1cad86
Mark the hook as experimental
youknowriad May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
forgot about the native exports
  • Loading branch information
@aristath @youknowriad
aristath authored and youknowriad committed May 19, 2021
commit afa56ec892093b4967da266f332470996e97c980
2 changes: 1 addition & 1 deletion packages/components/src/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export { default as QueryControls } from './query-controls';
export { default as Notice } from './notice';
export { default as NoticeList } from './notice/list';
export { default as RadioControl } from './radio-control';
export { default as UnitControl } from './unit-control';
export { default as UnitControl, useCustomUnits } from './unit-control';
export { default as Disabled } from './disabled';

// Higher-Order Components
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/unit-control/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,4 +177,5 @@ function UnitControl( {
);
}

export { useCustomUnits } from './utils';
export default memo( withPreferredColorScheme( UnitControl ) );