Writing flow: gradually 'select all' layers of nested blocks #31859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Enhancement
ellatrix
commented
May 15, 2021
| useCallback( | ||
| ( event ) => { | ||
| event.preventDefault(); | ||
| multiSelect( |
Member
Author
There was a problem hiding this comment.
I only saw now that these shortcuts are duplicated here, while also being in writing flow. This doesn't make any sense. The select all shortcut should only work from a focussed block upwards. These global shortcuts will also give problems when you focus something outside the block editor and press cmd+a. In other words, it should never be a global behaviour. Additionally it will give problems in the iframe editor when we remove event bubbling through the iframe.
Contributor
There was a problem hiding this comment.
There are some related issues. I found #19102 and #22689 in a quick search.
I think registerShortcut should ideally still be called as I believe that makes the shortcut display in the shortcut help modal. And then the code in useSelectAll could reference that registered shortcut.
That would also have the side effect of allowing a plugin to unregister the shortcut or change the shortcut keys. This is an interesting one because it uses the same key combination as the browser shortcut, so there's a question over how that would work..
Member
Author
There was a problem hiding this comment.
You're right, I modified it to use registerShortcut again.
|
Size Change: -6 B (0%) Total Size: 1.62 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/gradual-select-all
branch
2 times, most recently
from
e18b406 to
4133e78
Compare
talldan
approved these changes
May 19, 2021
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
This works really well, thanks!
I also tested unregistering the shortcut and that issue is now fixed too.
8 tasks
ellatrix
force-pushed
the
try/gradual-select-all
branch
from
4133e78 to
202680d
Compare
ellatrix
force-pushed
the
try/gradual-select-all
branch
from
c93ee27 to
8012e49
Compare
jffng
pushed a commit
that referenced
this pull request
May 19, 2021
This was referenced May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28267.
Fixes #22689.
Allows you to gradually select blocks through layers of nested blocks.
How has this been tested?
Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).