Fix/arrow key into textarea #3193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g in two different contexts Esentially when placing the caret into a new section while moving through the document in reverse we expect to put it at the end of the section. However when detecting if we are at the edge of the section going in reverse we expect the caret to be at the start of the section. The test was erronously expecting the two to be the same thing because they both used the flag "isReverse".
Codecov Report
@@ Coverage Diff @@
## master #3193 +/- ##
=======================================
Coverage 31.36% 31.36%
=======================================
Files 223 223
Lines 6393 6393
Branches 1136 1136
=======================================
Hits 2005 2005
Misses 3685 3685
Partials 703 703
Continue to review full report at Codecov.
|
ellatrix
approved these changes
Oct 29, 2017
Member
ellatrix
left a comment
ellatrix
left a comment
There was a problem hiding this comment.
Works great. Sorry I didn't catch this.
editor/utils/dom.js
Outdated
| if ( includes( [ 'INPUT', 'TEXTAREA' ], container.tagName ) ) { | ||
| container.focus(); | ||
| if ( isReverse ) { | ||
| if ( ! isReverse ) { |
Member
There was a problem hiding this comment.
Minor: When negating, I usually prefer to swap the blocks for readability. E.g.
! isSomething ? a() : b()to
isSomething ? b() : a()
Author
There was a problem hiding this comment.
Ok I will make that minor change and then merge.
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Arrow keying up or down through the document would jump to the opposite cursor position to the expected for textarea elements (for example the code block).
For example pressing down arrow when above a code block would jump straight to the end of the code block and when pressing up arrow while below the code block would jump to the start.
I have inverted the condition so that the behaviour of the method placeCaretAtHorizontalEdge matches the comment on the method for the parameter isReverse and it now behaves consistently with the contenteditable sections.
I also fixed a test which was erroneously conflating isReverse to mean the same thing in two different contexts.
How Has This Been Tested?
Manually and with the already existing automated tests.
Screenshots (jpeg or gifs if applicable):
Types of changes
Bug fix
Checklist: