Skip to content

Mobile: update image size picker #31963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enejb merged 9 commits into from
Jul 7, 2021
Merged

Mobile: update image size picker #31963

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d4dfa0b
Update Bottom Sheet Select Control to accept a label icon
enejb May 19, 2021
6a876f8
Update the Image block to use Bottom Sheet Select Control
enejb May 19, 2021
53a8fca
Minor code fixes
enejb May 19, 2021
48006df
fix goof
enejb May 19, 2021
fd2255d
Fix code style
enejb May 19, 2021
0308f6a
Make sure that we always recaculate the possible sizeOptions.
enejb Jun 30, 2021
11abffa
Remove lodash find, isEmpty, map and filter
enejb Jun 30, 2021
e284998
Double check that that we are dealing with arrays before proceeding.
enejb Jun 30, 2021
37be821
Use the same icon - fullscreen
enejb Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use the same icon - fullscreen
  • Loading branch information
@enejb
enejb committed Jul 5, 2021
commit 37be82119d1067bfd690b2a1653cd1a93c0370d6
4 changes: 2 additions & 2 deletions packages/block-library/src/image/edit.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import { withSelect, withDispatch } from '@wordpress/data';
import {
image as placeholderIcon,
replace,
expand,
fullscreen,
textColor,
} from '@wordpress/icons';
import { store as coreStore } from '@wordpress/core-data';
Expand Down Expand Up @@ -552,7 +552,7 @@ export class ImageEdit extends Component {
<PanelBody>
{ image && sizeOptionsValid && (
<BottomSheetSelectControl
icon={ expand }
icon={ fullscreen }
label={ __( 'Size' ) }
options={ sizeOptions }
onChange={ this.onSizeChangeValue }
Expand Down