Skip to content

Add Text Alignment Support to the Pullquote Block #31996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
porada wants to merge 6 commits into from
Closed

Add Text Alignment Support to the Pullquote Block #31996

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dcd1dbb
Add support for text alignment
porada May 14, 2021
8225d47
Add support for `placeholder` in `AlignmentToolbar` component
porada May 14, 2021
7bd9453
Make text alignment toolbar icon reflect default values
porada May 14, 2021
f96f1d3
Prevent empty `class` attribute from appearing in block output
porada May 19, 2021
4b2abd4
Add fixtures
porada May 19, 2021
534e0cc
Fix broken fixtures
porada May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Prevent empty class attribute from appearing in block output
  • Loading branch information
@porada
porada committed May 19, 2021
commit f96f1d32cf94ffc3d6c6af3ba88bddd71ca5276d
15 changes: 8 additions & 7 deletions packages/block-library/src/pullquote/save.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,13 +58,14 @@ export default function save( { attributes } ) {
}

const blockquoteTextColorClass = getColorClassName( 'color', textColor );
const blockquoteClasses = classnames( {
[ `has-text-align-${ textAlign }` ]: textAlign,
...( isTextColorSet && {
'has-text-color': true,
[ blockquoteTextColorClass ]: blockquoteTextColorClass,
} ),
} );
const blockquoteClasses =
classnames( {
[ `has-text-align-${ textAlign }` ]: textAlign,
...( isTextColorSet && {
'has-text-color': true,
[ blockquoteTextColorClass ]: blockquoteTextColorClass,
} ),
} ) || undefined;

const blockquoteStyles = blockquoteTextColorClass
? undefined
Expand Down