Skip to content

Conversation

@gziolo
Copy link
Member

@gziolo gziolo commented May 19, 2021

Description

This PR wraps construct_wp_query_args with the check that will prefer the version shipped with WordPress core.

It also renames the file with the function to lib/compat/wordpress-5.8.php. This way we can keep all shims related to a given major version of WordPress colocated to simplify future removing.

@gziolo gziolo self-assigned this May 19, 2021
@gziolo gziolo added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts Backwards Compatibility Issues or PRs that impact backwards compatability labels May 19, 2021
@gziolo gziolo requested review from a team and youknowriad May 19, 2021 16:57
@youknowriad youknowriad merged commit 3f6ad24 into trunk May 19, 2021
@youknowriad youknowriad deleted the fix/construct-wp-query-args branch May 19, 2021 16:58
@github-actions github-actions bot added this to the Gutenberg 10.7 milestone May 19, 2021
jffng pushed a commit that referenced this pull request May 19, 2021
ntsekouras pushed a commit that referenced this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backwards Compatibility Issues or PRs that impact backwards compatability Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants